[webkit-reviews] review requested: [Bug 100865] Warn in the inspector console when using dpi and dpcm units outside of media="print" : [Attachment 172963] Patch 3

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Nov 8 01:50:09 PST 2012


Alexander Shalamov <alexander.shalamov at gmail.com> has asked  for review:
Bug 100865: Warn in the inspector console when using dpi and dpcm units outside
of media="print"
https://bugs.webkit.org/show_bug.cgi?id=100865

Attachment 172963: Patch 3
https://bugs.webkit.org/attachment.cgi?id=172963&action=review

------- Additional Comments from Alexander Shalamov
<alexander.shalamov at gmail.com>
- reportMediaQueryWarning => reportMediaQueryWarningIfNeeded
- addWarningMessageToConsole => addResolutionWarningMessageToConsole
- add asserts for null document, null css value or css value that is not dpcm /
dpi


More information about the webkit-reviews mailing list