[webkit-reviews] review denied: [Bug 101026] Web Inspector: Settings screen: some panel shortcuts are missing : [Attachment 172548] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied eustas.bug at gmail.com's request
for review:
Bug 101026: Web Inspector: Settings screen: some panel shortcuts are missing
https://bugs.webkit.org/show_bug.cgi?id=101026

Attachment 172548: Patch
https://bugs.webkit.org/attachment.cgi?id=172548&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172548&action=review


> Source/WebCore/ChangeLog:14
> +	   More chanhes: add JsDoc annotations to ShortcutScreen and change
"key"

typo: chanhes-> changes

> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:76
> +	   var incrementBy10 =
WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementValue.concat(WebInsp
ector.ElementsPanelDescriptor.ShortcutKeys.DecrementValue);

Remove this line.

> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:79
> +	  
stylesPaneSection.addAlternateKeys(WebInspector.ElementsPanelDescriptor.Shortcu
tKeys.DecrementBy10, WebInspector.UIString("Decrement by %f", 10));

We should be consistent and use single entry "Increment/Decrement by 10" here
as for 0.1 and 100

> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:81
> +	   var incrementDecrementBy100 =
WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy01.concat(WebInspe
ctor.ElementsPanelDescriptor.ShortcutKeys.DecrementBy01);

incrementDecrementBy100 -> incrementDecrementBy01

> Source/WebCore/inspector/front-end/ElementsPanelDescriptor.js:84
> +	   var incrementDecrementBy01 =
WebInspector.ElementsPanelDescriptor.ShortcutKeys.IncrementBy100.concat(WebInsp
ector.ElementsPanelDescriptor.ShortcutKeys.DecrementBy100);

incrementDecrementBy01 -> incrementDecrementBy100. Looks like there is a
mistake in shortcut description for .1 and 100