[webkit-reviews] review denied: [Bug 101294] While absolute positioning is put before the first flexitem, flexitems will move to a new line. : [Attachment 172928] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 22:01:55 PST 2012


Ojan Vafai <ojan at chromium.org> has denied wayfind <whyer1 at gmail.com>'s request
for review:
Bug 101294: While absolute positioning is put before the first flexitem,
flexitems will move to a new line.
https://bugs.webkit.org/show_bug.cgi?id=101294

Attachment 172928: Patch
https://bugs.webkit.org/attachment.cgi?id=172928&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172928&action=review


This patch doesn't seem to apply to tip of tree (see all the bot failures).

> Source/WebCore/ChangeLog:10
> +		If there is an absolutely positioned flex item before other
items in a container and the container is set to "-webkit-flex-flow: row wrap",
the flex item after the absolutely positioned will move to a new line.
> +		This issue has to do with
RenderFlexibleBox::computeNextFlexLine. When determing line breaks, the
algorithm sees if 1) the total width exceeds lineBreakLength and 2) whether
orderedChildren is non-empty.  But then, if the total width exceeds
lineBreakLength and there's only absolutely positioned elemments in
orderedChildren then the conditions are met and the algorithm mistakenly breaks
the line.
> +		The solution is to see if orderedChildren collects at least a
flex item. If it does, break the line.

Please use only spaces and not tabs.


More information about the webkit-reviews mailing list