[webkit-reviews] review denied: [Bug 101458] Fix compile warning [-Wsign-compare] : [Attachment 172894] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 17:33:48 PST 2012


Alexey Proskuryakov <ap at webkit.org> has denied Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 101458: Fix compile warning [-Wsign-compare]
https://bugs.webkit.org/show_bug.cgi?id=101458

Attachment 172894: Patch
https://bugs.webkit.org/attachment.cgi?id=172894&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
As discussed on IRC, this doesn't seem right either, because casting
numeric_limits<size_t>::max() to off_t does not necessarily work (and in fact,
it does not work on your platform, where they have the same width, so the
result becomes negative).


More information about the webkit-reviews mailing list