[webkit-reviews] review denied: [Bug 101517] [EFL][WK2] MiniBrowser refactoring for the consistant naming. : [Attachment 172885] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 17:23:18 PST 2012


Gyuyoung Kim <gyuyoung.kim at samsung.com> has denied Byungwoo Lee
<bw80.lee at samsung.com>'s request for review:
Bug 101517: [EFL][WK2] MiniBrowser refactoring for the consistant naming.
https://bugs.webkit.org/show_bug.cgi?id=101517

Attachment 172885: Patch
https://bugs.webkit.org/attachment.cgi?id=172885&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172885&action=review


Should we change existing naming ? Christophe, do you agree this change ?

> Tools/MiniBrowser/efl/main.c:102
> +static Browser_Window *find_window_with_elm_window(Evas_Object *elm_window)

browser_window_find is more close EFL style.


More information about the webkit-reviews mailing list