[webkit-reviews] review granted: [Bug 101285] webkitpy: integrate pylint into check-webkit-style, part I : [Attachment 172457] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 16:24:54 PST 2012


Ojan Vafai <ojan at chromium.org> has granted Dirk Pranke <dpranke at chromium.org>'s
request for review:
Bug 101285: webkitpy: integrate pylint into check-webkit-style, part I
https://bugs.webkit.org/show_bug.cgi?id=101285

Attachment 172457: Patch
https://bugs.webkit.org/attachment.cgi?id=172457&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172457&action=review


> Tools/Scripts/webkitpy/style/checkers/python.py:100
> +	   self._script_dir =
os.path.abspath(os.path.dirname(os.path.dirname(os.path.dirname(os.path.dirname
(__file__)))))

Can we instead walk up the path until we find a known directory and then walk
down the the script_dir if the script_dir is not the known directory?


More information about the webkit-reviews mailing list