[webkit-reviews] review granted: [Bug 101144] SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove : [Attachment 172866] Fixed password-echo-passnode.html

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 16:17:22 PST 2012


Enrica Casucci <enrica at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 101144: SimplifyMarkupCommand takes a disproportionally long time to run
when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144

Attachment 172866: Fixed password-echo-passnode.html
https://bugs.webkit.org/attachment.cgi?id=172866&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
It would have been nice not having to repeat all the logic around
ShouldAssumeContentIsAlwaysEditable in every command affected. Is there any way
to move it to the parent class? I know some of the commands are simple and
other are composite. If there is no way to move it to a common place it is fine
too, not holding the review for this.


More information about the webkit-reviews mailing list