[webkit-reviews] review denied: [Bug 101510] [BlackBerry] Verify touched element using the rootEditableElement : [Attachment 172870] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Nima Ghanavatian
<nima.ghanavatian at gmail.com>'s request for review:
Bug 101510: [BlackBerry] Verify touched element using the rootEditableElement
https://bugs.webkit.org/show_bug.cgi?id=101510

Attachment 172870: Patch
https://bugs.webkit.org/attachment.cgi?id=172870&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172870&action=review


Some stuff to fix, have a look at the style problem too and that the patch
applies generally (guess we need to watch the bots).

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:170
> +	   WebCore::Node* parentNode;

You only need this in the while loop.

> Source/WebKit/blackberry/WebKitSupport/FatFingers.h:174
> +		   break;

Can you use parentElement here as well?

> Source/WebKit/blackberry/WebKitSupport/InputHandler.cpp:713
> +    Element* parentElement;

You only need this in the while loop.