[webkit-reviews] review granted: [Bug 101303] Fixed position elements that are out of view still end up forcing non-threaded scrolling : [Attachment 172850] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Beth Dakin
<bdakin at apple.com>'s request for review:
Bug 101303: Fixed position elements that are out of view still end up forcing
non-threaded scrolling
https://bugs.webkit.org/show_bug.cgi?id=101303

Attachment 172850: Patch
https://bugs.webkit.org/attachment.cgi?id=172850&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172850&action=review


> Source/WebCore/page/scrolling/mac/ScrollingCoordinatorMac.h:95
> +    virtual bool hasNonLayerFixedObjects(FrameView*) const { return false; }


I think this function name is wrong. I think it should be
hasVisibleSlowRepaintFixedObjects() or something.

>
LayoutTests/platform/mac/tiled-drawing/fixed/absolute-inside-out-of-view-fixed.
html:40
> +	     if (window.internals) {
> +	       document.getElementById('results').innerText =
internals.scrollingStateTreeAsText(document);
> +	       testRunner.notifyDone();

I think it would also be good for this test to dump the layer tree, since
you're changing compositing behavior. Or add another test under compositing/
that does this, and isn't tied to tiled drawing.