[webkit-reviews] review granted: [Bug 101110] [V8] IntrusiveDOMWrapperMap should be usable for more than just Nodes : [Attachment 172855] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 12:17:00 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Adam Barth
<abarth at webkit.org>'s request for review:
Bug 101110: [V8] IntrusiveDOMWrapperMap should be usable for more than just
Nodes
https://bugs.webkit.org/show_bug.cgi?id=101110

Attachment 172855: Patch
https://bugs.webkit.org/attachment.cgi?id=172855&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172855&action=review


> Source/WebCore/bindings/v8/DOMDataStore.h:63
> -    inline v8::Handle<v8::Object> get(Node* object) const
> +    inline v8::Handle<v8::Object> get(ScriptWrappable* object) const

I'm pretty sure it will work, but if something in your original patch is the
culprit of the regression, I might want to suspect this part (just an
intuition).


More information about the webkit-reviews mailing list