[webkit-reviews] review granted: [Bug 101238] Fix asm operand type for weakCompareAndSwap on ARM_THUMB2 : [Attachment 172369] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 12:08:27 PST 2012


Benjamin Poulain <benjamin at webkit.org> has granted Hans Wennborg
<hans at chromium.org>'s request for review:
Bug 101238: Fix asm operand type for weakCompareAndSwap on ARM_THUMB2
https://bugs.webkit.org/show_bug.cgi?id=101238

Attachment 172369: Patch
https://bugs.webkit.org/attachment.cgi?id=172369&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172369&action=review


> Source/WTF/ChangeLog:20
> +	   Also make 'result' for the X86 version an 'unsigned char' to make it

> +	   more clear that it is a byte.

I honestly have no clue about that one, but that seems consistent with the old
code.


More information about the webkit-reviews mailing list