[webkit-reviews] review granted: [Bug 101071] [CSS Shaders] Remove the dependency on CustomFilterValidatedProgram from CustomFilterRenderer : [Attachment 172822] Patch V1

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 101071: [CSS Shaders] Remove the dependency on CustomFilterValidatedProgram
from CustomFilterRenderer
https://bugs.webkit.org/show_bug.cgi?id=101071

Attachment 172822: Patch V1
https://bugs.webkit.org/attachment.cgi?id=172822&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172822&action=review


> Source/WebCore/ChangeLog:9
> +	   used to delay the compilation of the shader until it was really
needed. Instead, the FitlerEffectRenderer

Typo: Fitler

> Source/WebCore/platform/graphics/filters/CustomFilterRenderer.cpp:122
> +    if (!m_compiledProgram.get() || !m_compiledProgram->isInitialized())

You can just do !m_compiledProgram rather than adding .get()