[webkit-reviews] review granted: [Bug 101484] Clean up confused use of Document::renderer and renderView : [Attachment 172828] Patch

[bugzilla-daemon at webkit.org]

Ojan Vafai <ojan at chromium.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 101484: Clean up confused use of Document::renderer and renderView
https://bugs.webkit.org/show_bug.cgi?id=101484

Attachment 172828: Patch
https://bugs.webkit.org/attachment.cgi?id=172828&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172828&action=review


>>> Source/WebCore/dom/Element.cpp:652
>>> +	 return
document()->view()->contentsToScreen(renderer()->absoluteBoundingBoxRectIgnorin
gTransforms());
>> 
>> Don't you still need to grab the frameView()? I'm confused how this
compiled.
> 
> document()->view() is the FrameView! :) document()->renderView() is the
RenderView. Alas we have so many views.
> 
> This code was crazy before because it expanded to:
> 
> renderer()->m_node->document()->renderView()->frameView() so we went out into
the render tree only to come back to ourself through m_node and then to the
document and back into the render tree and then finally to the frame view... it
was the rube goldberg of methods.

Oh right. I see. Lol.