[webkit-reviews] review denied: [Bug 101453] Rename the windowRect, pageRect etc to something more sane : [Attachment 172792] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Nov 7 10:44:40 PST 2012
Simon Fraser (smfr) <simon.fraser at apple.com> has denied Kenneth Rohde
Christiansen <kenneth at webkit.org>'s request for review:
Bug 101453: Rename the windowRect, pageRect etc to something more sane
https://bugs.webkit.org/show_bug.cgi?id=101453
Attachment 172792: Patch
https://bugs.webkit.org/attachment.cgi?id=172792&action=review
------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172792&action=review
It's not clear what "physical" means.
> Source/WebCore/ChangeLog:8
> + Rename the methods and use there of.
You need to explain your new terminology here. I don't really know what
"physical" means. Should I get out a ruler and measure my screen?
More information about the webkit-reviews
mailing list