[webkit-reviews] review denied: [Bug 99984] [SVG] SVGPreserveAspectRatio::transformRect is done incorrectly in 'slice' mode : [Attachment 172820] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Branimir Lambov
<blambov at google.com>'s request for review:
Bug 99984: [SVG] SVGPreserveAspectRatio::transformRect is done incorrectly in
'slice' mode
https://bugs.webkit.org/show_bug.cgi?id=99984

Attachment 172820: Patch
https://bugs.webkit.org/attachment.cgi?id=172820&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
This is the same test as LayoutTests/svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
You don't need to upload it again. I wonder why we don't have the same problem
in other cases like LayoutTests/svg/W3C-SVG-1.1/coords-viewattr-02-b.svg Which
does exactly the same on <image> and does not fail. I would like to know why it
doesn't fail before approving this patch. Maybe it is a bug in FEImage instead,
maybe SVGImageElement has hacks that need to be removed. Maybe the test is
slightly different, in which case we need tests for <image> as well.