[webkit-reviews] review granted: [Bug 101356] Web Inspector: wrong output for empty object {} : [Attachment 172813] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 101356: Web Inspector: wrong output for empty object {}
https://bugs.webkit.org/show_bug.cgi?id=101356

Attachment 172813: Patch
https://bugs.webkit.org/attachment.cgi?id=172813&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172813&action=review


> Source/WebCore/inspector/InjectedScriptSource.js:826
> +	       this._generateProtoPreview(o, properties, elementsToDump);

Isn't properties redundant?

> Source/WebCore/inspector/InjectedScriptSource.js:834
> +    _generateProtoPreview: function(object, properties, elementsToDump)

properties === this.preview.properties, why is it needed?

> Source/WebCore/inspector/InjectedScriptSource.js:880
> +		       description  = this._abbreviateString(/** @type {string}
*/ (injectedScript._describe(value)), maxLength, subtype === "regexp");

extra space before =

> Source/WebCore/inspector/front-end/ConsoleMessage.js:333
> +		   span.textContent = "function";

Please remove braces.
Or you could just replace else branches with
span.textContent = property.type === "function" ? "function" : property.value;