[webkit-reviews] review granted: [Bug 101226] [Qt] Open link in this window action : [Attachment 172803] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has granted Allan Sandfeld Jensen
<allan.jensen at digia.com>'s request for review:
Bug 101226: [Qt] Open link in this window action
https://bugs.webkit.org/show_bug.cgi?id=101226

Attachment 172803: Patch
https://bugs.webkit.org/attachment.cgi?id=172803&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172803&action=review


> Source/WebKit/qt/Api/qwebpage.cpp:1698
> +    \value OpenLinkInThisWindow Open the current link without opening a new
window. Used on links that would default to opening a new window. (Added in Qt
5.0)

"Used on links that would default to opening a new window" maybe that should
also include frames? Like

"Used on links that would default to opening in another frame or a new window"
?