[webkit-reviews] review granted: [Bug 101470] [V8] Main world should have one DOMDataStore : [Attachment 172794] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Nov 7 07:16:28 PST 2012


Kentaro Hara <haraken at chromium.org> has granted Dan Carney
<dcarney at google.com>'s request for review:
Bug 101470: [V8] Main world should have one DOMDataStore
https://bugs.webkit.org/show_bug.cgi?id=101470

Attachment 172794: Patch
https://bugs.webkit.org/attachment.cgi?id=172794&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172794&action=review


You might also want to rename defaultStore to mainWorldStore.

> Source/WebCore/bindings/v8/DOMDataStore.cpp:78
> +	   return context->world()->isolatedWorldDomDataStore();

Nit: I guess that WebKit is likely to use isolatedWorld*DOM*DataStore.


More information about the webkit-reviews mailing list