[webkit-reviews] review denied: [Bug 101085] Web Inspector: Fix heap snapshots counted several times by NMI : [Attachment 172107] Patch

[bugzilla-daemon at webkit.org]

Yury Semikhatsky <yurys at chromium.org> has denied Alexei Filippov
<alph at chromium.org>'s request for review:
Bug 101085: Web Inspector: Fix heap snapshots counted several times by NMI
https://bugs.webkit.org/show_bug.cgi?id=101085

Attachment 172107: Patch
https://bugs.webkit.org/attachment.cgi?id=172107&action=review

------- Additional Comments from Yury Semikhatsky <yurys at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172107&action=review


>>> Source/WebCore/inspector/InspectorProfilerAgent.cpp:510
>>> +	 static ScriptProfilerSingletonProxy scriptProfilerSingletonProxy;
>> 
>> static variable will not work for workers.
> 
> Sorry, could you please elaborate. Why not?

The profiler agent can belong to a dedicated worker that lives on its own
thread and ScriptProfilerSingletonProxy can be called concurrently.