[webkit-reviews] review granted: [Bug 101420] Function adoptNS and adoptCF should not generate memory leak diagnostic with Clang Static Analyzer : [Attachment 172697] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Remy "Psy" Demarest
<rdemarest at apple.com>'s request for review:
Bug 101420: Function adoptNS and adoptCF should not generate memory leak
diagnostic with Clang Static Analyzer
https://bugs.webkit.org/show_bug.cgi?id=101420

Attachment 172697: Patch
https://bugs.webkit.org/attachment.cgi?id=172697&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172697&action=review


Nice patch. I did not know about those annotations.

> Source/WTF/ChangeLog:9
> +	   Defines CF_RELEASES_ARGUMENT and NS_RELEASES_ARGUMENT if not
available, uses in function declarations.

Ok, not a native English speaker here. :)
Should Define and use really take a S? Is the subject implicit or something?