[webkit-reviews] review requested: [Bug 101421] StringBuilder::append(UChar) with an 8 bit quantity shouldn't change the contents to 16 bits : [Attachment 172720] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 6 22:12:34 PST 2012
Michael Saboff <msaboff at apple.com> has asked for review:
Bug 101421: StringBuilder::append(UChar) with an 8 bit quantity shouldn't
change the contents to 16 bits
https://bugs.webkit.org/show_bug.cgi?id=101421
Attachment 172720: Patch
https://bugs.webkit.org/attachment.cgi?id=172720&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
This appears to be a progression on most of the Parser performance tests. Here
is a comparison of the arithmetic average of 8 test runs for the parser tests:
Test Baseline With Patch Change
html-parser 2026.46ms 1989.21ms +2.8%
html5-full-render 4274.28ms 4176.83ms +2.3%
innerHTML-setter 263.14runs/s 269.21runs/s +2.3%
simple-url 48.47runs/s 51.14runs/s +5.5%
textarea-parsing 82.73runs/s 83.00runs/s +0.3%
tiny-inner-HTML 5.08runs/s 5.07runs/s -0.2%
url-parser 111.32runs/r 117.61runs/s +5.7%
xml-parser 7.07runs/s 7.20runs/s +1.8%
More information about the webkit-reviews
mailing list