[webkit-reviews] review granted: [Bug 100173] Re-order variables in BidiRun and LayoutState : [Attachment 172675] Addresses comments

[bugzilla-daemon at webkit.org]

Eric Seidel <eric at webkit.org> has granted Chris Evans <cevans at google.com>'s
request for review:
Bug 100173: Re-order variables in BidiRun and LayoutState
https://bugs.webkit.org/show_bug.cgi?id=100173

Attachment 172675: Addresses comments
https://bugs.webkit.org/attachment.cgi?id=172675&action=review

------- Additional Comments from Eric Seidel <eric at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172675&action=review


Otherwsie LGTM.

> Source/WebCore/platform/text/BidiResolver.h:151
> +    bool m_subClass1:1; // Opaque subclass storage; packed here to save
space.

I would just call this m_hasHyphen and add a comment that it's used by a
subclass (and that it's a layering violation, but that we do it to save N bytes
per object).