[webkit-reviews] review granted: [Bug 100997] Add application occlusion criterion to enable/disable process suppression on Mac : [Attachment 172667] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Kiran Muppala
<cmuppala at apple.com>'s request for review:
Bug 100997: Add application occlusion criterion to enable/disable process
suppression on Mac
https://bugs.webkit.org/show_bug.cgi?id=100997

Attachment 172667: Patch
https://bugs.webkit.org/attachment.cgi?id=172667&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172667&action=review


r=mw, thank you for your patience.

> Source/WebKit2/ChangeLog:38
> +	   (NetworkProcessProxy):

I didn't make it clear that my comment was general, not just about those two
lines.

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:293
> +	      
contexts[i]->sendToAllProcesses(Messages::WebProcess::SetApplicationIsOccluded(
true));

Yes, it makes sense to keep the message sent directly to WebProcesses, because
WebContext is a "manager" for those.