[webkit-reviews] review granted: [Bug 101127] Reduce parser overhead in JSC : [Attachment 172646] Patch

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 101127: Reduce parser overhead in JSC
https://bugs.webkit.org/show_bug.cgi?id=101127

Attachment 172646: Patch
https://bugs.webkit.org/attachment.cgi?id=172646&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172646&action=review


R=me! :-D

> Source/JavaScriptCore/heap/Heap.cpp:497
>	       }
>	   }
>  #endif
> -    
> +
>	   if (m_globalData->codeBlocksBeingCompiled.size()) {
>	       GCPHASE(VisitActiveCodeBlock);
>	       for (size_t i = 0; i <
m_globalData->codeBlocksBeingCompiled.size(); i++)
>		  
m_globalData->codeBlocksBeingCompiled[i]->visitAggregate(visitor);
>	   }
> -    
> +
>	   {
>	       GCPHASE(VisitMachineRoots);
>	       MARK_LOG_ROOT(visitor, "C++ Stack");

Kill!

> Source/JavaScriptCore/jit/JIT.cpp:339
> +	   case op_init_global_const_nop:
> +	       NEXT_OPCODE(op_init_global_const_nop);

When would this survive into the JIT?