[webkit-reviews] review denied: [Bug 101386] [BlackBerry] Pushing window.external.* events to webplatform : [Attachment 172636] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied otcheung at rim.com's request for review:
Bug 101386: [BlackBerry] Pushing window.external.* events to webplatform
https://bugs.webkit.org/show_bug.cgi?id=101386

Attachment 172636: Patch
https://bugs.webkit.org/attachment.cgi?id=172636&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172636&action=review


Small fixies to do.

> Source/WebKit/blackberry/ChangeLog:8
> +	   Adding calls to trigger window.external events so we could handle
them on the

we could -> we can. Yes we can!

> Source/WebKit/blackberry/Api/WebPageClient.h:266
> +    virtual int  isSearchProviderInstalled(const Platform::String& newURL) =
0;

newURL can be left off here.