[webkit-reviews] review denied: [Bug 101339] [WTF] Introduce stream operators for WTF::StringBuilder : [Attachment 172563] patch v2

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 12:24:26 PST 2012


Benjamin Poulain <benjamin at webkit.org> has denied Mikhail Pozdnyakov
<mikhail.pozdnyakov at intel.com>'s request for review:
Bug 101339: [WTF] Introduce stream operators for WTF::StringBuilder
https://bugs.webkit.org/show_bug.cgi?id=101339

Attachment 172563: patch v2
https://bugs.webkit.org/attachment.cgi?id=172563&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
We do not use stream operator intentionally in WebKit. We restrict our use of
C++ to a certain subset, and typically that does not include stream operators.

Moreover, there are good reasons for having append(), appendNumber() and
appendLiteral().

Also note that more compact code is not a goal of the project. Improved
readability is one.


More information about the webkit-reviews mailing list