[webkit-reviews] review granted: [Bug 101267] Hook up the remote layer tree drawing area to an environment variable : [Attachment 172418] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Nov 6 10:30:31 PST 2012


Andreas Kling <kling at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 101267: Hook up the remote layer tree drawing area to an environment
variable
https://bugs.webkit.org/show_bug.cgi?id=101267

Attachment 172418: Patch
https://bugs.webkit.org/attachment.cgi?id=172418&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172418&action=review


>>> Source/WebKit2/UIProcess/API/mac/WKView.mm:2282
>>> +	     if (getenv("WK_USE_REMOTE_LAYER_TREE_DRAWING_AREA"))
>> 
>> User defaults offer greater flexibility and convenience over environment
variables. Why did you choose to use an environment variable here?
> 
> Because I don't want this to persist. I did the same thing when bringing up
the tiled drawing area.

fine.


More information about the webkit-reviews mailing list