[webkit-reviews] review granted: [Bug 100763] [CSS Exclusions] Store ExclusionPolygonEdge vertices in clockwise order : [Attachment 172606] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 100763: [CSS Exclusions] Store ExclusionPolygonEdge vertices in clockwise
order
https://bugs.webkit.org/show_bug.cgi?id=100763

Attachment 172606: Patch
https://bugs.webkit.org/attachment.cgi?id=172606&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172606&action=review


> Source/WebCore/ChangeLog:22
> +	   (WebCore):

Please leave lines like this out of the change log even though the script
generates them. For extra credit, get the script fixed to not add these.

> Source/WebCore/ChangeLog:24
> +	   (WebCore::appendIntervalX): Made this an inline.

Why?

> Source/WebCore/rendering/ExclusionPolygon.cpp:103
> +    bool clockwise = true;

No reason to define and initialize this here.

> Source/WebCore/rendering/ExclusionPolygon.cpp:111
> +    FloatPoint prevVertex = vertexAt((minVertexIndex -1 + nVertices) %
nVertices);

Missing space after the "-" here. Also might be clearer to add nVertices before
subtracting 1 so we don’t rely on underflow behavior, even though that behavior
is defined.

> Source/WebCore/rendering/ExclusionPolygon.cpp:112
> +    clockwise = determinant(vertexAt(minVertexIndex) - prevVertex,
nextVertex - prevVertex) > 0;

The boolean should be initialized here.