[webkit-reviews] review granted: [Bug 101013] Lexer::scanRegExp, create 8 bit pattern and flag Identifiers from 16 bit source when possible : [Attachment 172135] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 101013: Lexer::scanRegExp, create 8 bit pattern and flag Identifiers from
16 bit source when possible
https://bugs.webkit.org/show_bug.cgi?id=101013

Attachment 172135: Patch
https://bugs.webkit.org/attachment.cgi?id=172135&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172135&action=review


> Source/JavaScriptCore/parser/Lexer.cpp:1689
>  template <typename T>
> +static inline void orCharacter(UChar&, UChar);

I don’t think the static here has any effect anything.

> Source/JavaScriptCore/parser/Lexer.cpp:1692
> +template <>
> +inline void orCharacter<LChar>(UChar&, UChar) { }

Don’t we want static here?

> Source/JavaScriptCore/parser/Lexer.cpp:1695
> +template <>
> +inline void orCharacter<UChar>(UChar& orAccumulator, UChar character)

Don’t we want static here?

> Source/JavaScriptCore/parser/Lexer.cpp:1707
> +    UChar orAllChars = 0;

It’s awkward that “or all chars” is a verb phrase. I’d suggest a noun phrase,
"charactersOredTogether" or something like that.