[webkit-reviews] review denied: [Bug 101348] CustomEvent: Allow taking in a serialized value during initialization. : [Attachment 172604] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has denied sadrul at chromium.org's request for
review:
Bug 101348: CustomEvent: Allow taking in a serialized value during
initialization.
https://bugs.webkit.org/show_bug.cgi?id=101348

Attachment 172604: Patch
https://bugs.webkit.org/attachment.cgi?id=172604&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172604&action=review


> Source/WebCore/bindings/v8/custom/V8CustomEventCustom.cpp:56
> +	   return
ScriptValue::deserialize(ScriptState::forContext(info.Holder()->CreationContext
()), serialized.get()).v8Value();

There's no reason to use the ScriptValue helpers when you're inside the
bindings.  You can just call SerialziedScriptValue::deserialize directly. 
ScriptValue is an abstraction that lets you share code between V8 and JSC.