[webkit-reviews] review granted: [Bug 101215] [WK2][EFL][GTK] early return of checkSpellingOfString treats correct words as misspelled : [Attachment 172534] fix checkSpellingOfString in TextCheckerEnchant class

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 101215: [WK2][EFL][GTK] early return of checkSpellingOfString treats
correct words as misspelled
https://bugs.webkit.org/show_bug.cgi?id=101215

Attachment 172534: fix checkSpellingOfString in TextCheckerEnchant class
https://bugs.webkit.org/attachment.cgi?id=172534&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172534&action=review


As I said on IRC, this makes sense to me, I'd recommend removing the assingment
from the original WebProcess call site to make it clearer that those values do
not get here.

> Source/WebCore/platform/text/enchant/TextCheckerEnchant.cpp:71
> +    // Assume that the words in the @a string are spelled correctly.

This @a in the comment looks like a formatting annotation which doesn't make
sense in private/cross-platform comments.