[webkit-reviews] review requested: [Bug 101257] [WTF] Add replaceWithLiteral() method to WTF::String : [Attachment 172546] Patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <christophe.dumez at intel.com> has asked  for review:
Bug 101257: [WTF] Add replaceWithLiteral() method to WTF::String
https://bugs.webkit.org/show_bug.cgi?id=101257

Attachment 172546: Patch
https://bugs.webkit.org/attachment.cgi?id=172546&action=review

------- Additional Comments from Christophe Dumez <christophe.dumez at intel.com>
Take Benjamin's feedback into consideration:
- Rename String::replace() with String::replaceWithString() to be safe
- No longer export "replace(UChar, const UChar*, unsigned replacementLength)"
- Replace repStrLength checks by replacement NULL-checks in new
StringImpl::replace() methods
- Add API tests from String::replaceWithString() and corresponding StringImpl
method
- Replace String::replace() by String::replaceWithLiteral() where appropriate
in the rest of WebKit