[webkit-reviews] review granted: [Bug 100922] [Shadow] ShadowRoot should know the existence of element having ElementShadow. : [Attachment 172514] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Nov 6 01:24:44 PST 2012
Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 100922: [Shadow] ShadowRoot should know the existence of element having
ElementShadow.
https://bugs.webkit.org/show_bug.cgi?id=100922
Attachment 172514: Patch
https://bugs.webkit.org/attachment.cgi?id=172514&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172514&action=review
> Source/WebCore/testing/Internals.cpp:332
> + ec = INVALID_ACCESS_ERR;
Let's take check-error-then do happy path pattern.
Pushing error path to late is unusual thus confusing.
More information about the webkit-reviews
mailing list