[webkit-reviews] review granted: [Bug 101284] RenderGeometryMap asserts when loading http://en.softonic.com/mac : [Attachment 172451] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <timothy_horton at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 101284: RenderGeometryMap asserts when loading http://en.softonic.com/mac
https://bugs.webkit.org/show_bug.cgi?id=101284

Attachment 172451: Patch
https://bugs.webkit.org/attachment.cgi?id=172451&action=review

------- Additional Comments from Tim Horton <timothy_horton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172451&action=review


Seems reasonable!

> Source/WebCore/page/FrameView.cpp:711
> +    // If we expect to update compositing after an incipient layout, don't
do so here.

incipient :\

> Source/WebCore/page/FrameView.cpp:1073
> +	   m_doingPreLayoutStyleUpdate = true;

TemporaryChange thing? Or I guess it doesn’t matter in this case.