[webkit-reviews] review granted: [Bug 100142] [chromium] Implement reference (url) filters on composited layers. : [Attachment 172398] Fix refcounting issue

[bugzilla-daemon at webkit.org]

James Robinson <jamesr at chromium.org> has granted Stephen White
<senorblanco at chromium.org>'s request for review:
Bug 100142: [chromium] Implement reference (url) filters on composited layers.
https://bugs.webkit.org/show_bug.cgi?id=100142

Attachment 172398: Fix refcounting issue
https://bugs.webkit.org/attachment.cgi?id=172398&action=review

------- Additional Comments from James Robinson <jamesr at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172398&action=review


R=me

> Source/WebCore/platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:45
> +    //    Old implementation, a la the draft spec, a straight-up scale,
> +    //    representing <feFunc[R|G|B] type="linear" slope="[amount]">
> +    //    (See
http://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#brightnessEquivalent
)
> +    // matrix[0] = matrix[6] = matrix[12] = amount;
> +    // matrix[18] = 1;

is there any reason to keep this around?