[webkit-reviews] review denied: [Bug 101144] SimplifyMarkupCommand takes a disproportionally long time to run when there are many nodes to remove : [Attachment 172359] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 11:38:34 PST 2012


Ojan Vafai <ojan at chromium.org> has denied Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 101144: SimplifyMarkupCommand takes a disproportionally long time to run
when there are many nodes to remove
https://bugs.webkit.org/show_bug.cgi?id=101144

Attachment 172359: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=172359&action=review

------- Additional Comments from Ojan Vafai <ojan at chromium.org>
There has to be a less hacky solution to this that performs well. The RAII
object doesn't need to hold on to the nodes. It just needs to keep them from
attaching. In its destructor we could walk the root editable elements tree and
attach anything that's not attached. That should perform comparably to what you
have here.


More information about the webkit-reviews mailing list