[webkit-reviews] review granted: [Bug 101204] Expose hit test related methods in public chromium port : [Attachment 172308] Add Changelog
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 5 09:59:49 PST 2012
Adam Barth <abarth at webkit.org> has granted Bo Liu <boliu at chromium.org>'s
request for review:
Bug 101204: Expose hit test related methods in public chromium port
https://bugs.webkit.org/show_bug.cgi?id=101204
Attachment 172308: Add Changelog
https://bugs.webkit.org/attachment.cgi?id=172308&action=review
------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172308&action=review
> Source/WebKit/chromium/public/WebHitTestResult.h:67
> + WEBKIT_EXPORT WebElement URLElement() const;
> +
> + WEBKIT_EXPORT WebURL absoluteImageURL() const;
> +
> + WEBKIT_EXPORT WebURL absoluteLinkURL() const;
> +
> + WEBKIT_EXPORT bool isContentEditable() const;
Please add comments explaining what this function do. Also URLElement is not
in correct style. Perhaps urlElement?
More information about the webkit-reviews
mailing list