[webkit-reviews] review requested: [Bug 101224] [GTK] Check DOM bindings API compatibility while building : [Attachment 172342] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has asked  for review:
Bug 101224: [GTK] Check DOM bindings API compatibility while building
https://bugs.webkit.org/show_bug.cgi?id=101224

Attachment 172342: Patch
https://bugs.webkit.org/attachment.cgi?id=172342&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
There's something I'm not sure about in this patch. It keeps a symbols file in
the source tree to compare with the symbols generated during the build and if
the changes are API comapatible the symbols file in the source tree is updated.
I'm not sure it's a good idea that the build updates a file in the source tree.
Most of the times the API changes, we don't notice it, so if the file has to be
update manually, we will miss it most of the times. We could make the build
fail even for compatible changes, to force update the symbols file, showing in
the error message if the changes are an API break or not, so that it's easy to
know whether we just need to update the file or we are breaking the API.