[webkit-reviews] review denied: [Bug 101223] [BlackBerry] ImageDiff build clean-up : [Attachment 172338] Patch

[bugzilla-daemon at webkit.org]

Rob Buis <rwlbuis at gmail.com> has denied Ming Xie <mxie at rim.com>'s request for
review:
Bug 101223: [BlackBerry] ImageDiff build clean-up
https://bugs.webkit.org/show_bug.cgi?id=101223

Attachment 172338: Patch
https://bugs.webkit.org/attachment.cgi?id=172338&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172338&action=review


Looks good, can be made a bit more robust.

> Tools/DumpRenderTree/blackberry/buildImageDiff.sh:6
> +OUTPUT_DIR="$RICHMOND_ROOT/webkit/WebKitBuild/ImageDiff"

It is probably better to abstract this a bit more and use the same build dir
variable CMake uses. So I guess this script needs an argument for that.