[webkit-reviews] review granted: [Bug 101211] Protect against resource deletion during iteration in MemoryCache::pruneDeadResourcesToSize : [Attachment 172325] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 06:37:30 PST 2012


Andreas Kling <kling at webkit.org> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 101211: Protect against resource deletion during iteration in
MemoryCache::pruneDeadResourcesToSize
https://bugs.webkit.org/show_bug.cgi?id=101211

Attachment 172325: patch
https://bugs.webkit.org/attachment.cgi?id=172325&action=review

------- Additional Comments from Andreas Kling <kling at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172325&action=review


Looks safe and mostly reasonable. r=me

> Source/WebCore/loader/cache/MemoryCache.cpp:311
> +	       // Protect prev so it can't get deleted during
destroyDecodedData().

prev -> 'previous'


More information about the webkit-reviews mailing list