[webkit-reviews] review granted: [Bug 101199] Disable registerProtocolHandler on Android : [Attachment 172304] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 5 04:54:59 PST 2012
Julien Chaffraix <jchaffraix at webkit.org> has granted Miguel Garcia
<miguelg at chromium.org>'s request for review:
Bug 101199: Disable registerProtocolHandler on Android
https://bugs.webkit.org/show_bug.cgi?id=101199
Attachment 172304: Patch
https://bugs.webkit.org/attachment.cgi?id=172304&action=review
------- Additional Comments from Julien Chaffraix <jchaffraix at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172304&action=review
LGTM, Adam is usually your man for such changes but it is simple enough.
> Source/WebKit/chromium/ChangeLog:8
> + Disalble registerProtocolHandler since it is not properly
implemented (yet) and could confuse developers trying to use it in android.
Typo: disalble.
Also let's be precise! Peter's phrasing was more accurate from this perspective
as it mentioned that it is a platform issue (reading your wording I thought it
was an issue in the feature).
More information about the webkit-reviews
mailing list