[webkit-reviews] review granted: [Bug 95962] Validate CSS Device Adaptation properties and resolve shorthands : [Attachment 172069] Patch

[bugzilla-daemon at webkit.org]

Alexis Menard (darktears) <alexis at webkit.org> has granted Thiago Marcos P.
Santos <tmpsantos at gmail.com>'s request for review:
Bug 95962: Validate CSS Device Adaptation properties and resolve shorthands
https://bugs.webkit.org/show_bug.cgi?id=95962

Attachment 172069: Patch
https://bugs.webkit.org/attachment.cgi?id=172069&action=review

------- Additional Comments from Alexis Menard (darktears) <alexis at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172069&action=review


>> Source/WebCore/css/CSSParser.cpp:10469
>> +	    break;
> 
> why not validPrimitive = (id == CSSValueAuto) || ....

but the way he wrote it follows the style of the file e.g. line 2140 for
example.