[webkit-reviews] review granted: [Bug 101164] Web Inspector: render message bubbles in CodeMirror experiment. : [Attachment 172243] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has granted Pavel Feldman
<pfeldman at chromium.org>'s request for review:
Bug 101164: Web Inspector: render message bubbles in CodeMirror experiment.
https://bugs.webkit.org/show_bug.cgi?id=101164

Attachment 172243: Patch
https://bugs.webkit.org/attachment.cgi?id=172243&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172243&action=review


> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:65
> +    this._widgets = [];

Looks like this._widgets is redundant, you only use it to iterate over all
widgets but this could be done using this._elementToWidget.

> Source/WebCore/inspector/front-end/CodeMirrorTextEditor.js:186
> +	       this._codeMirror.removeLineWidget(widget);

Shouldn't we remove an entry from elementToWidget map as well here?