[webkit-reviews] review granted: [Bug 101197] [EFL] Fix build warning in EWebLauncher/main.c : [Attachment 172298] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Nov 5 02:28:13 PST 2012
Kentaro Hara <haraken at chromium.org> has granted KyungTae Kim
<ktf.kim at samsung.com>'s request for review:
Bug 101197: [EFL] Fix build warning in EWebLauncher/main.c
https://bugs.webkit.org/show_bug.cgi?id=101197
Attachment 172298: Patch
https://bugs.webkit.org/attachment.cgi?id=172298&action=review
------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172298&action=review
>>> Tools/EWebLauncher/main.c:146
>>> + char *engine;
>>
>> According to the WebKit coding style, this should be 'char* engine' instead
of 'char *engine'. Same comments for the following variables.
>
> Kentaro, this is EFL simple application. So, we follow EFL coding style for
EWebLauncher.
Makes sense. Thanks for the clarification.
More information about the webkit-reviews
mailing list