[webkit-reviews] review granted: [Bug 99842] Touch operation corrupts screen when specifying other than overflow:visible in css : [Attachment 172286] The patch to fix this problem (WinCairo port)

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Nov 5 00:44:11 PST 2012


Hideki <yoshida-hxa at necst.nec.co.jp> has granted  review:
Bug 99842: Touch operation corrupts screen when specifying other than
overflow:visible in css
https://bugs.webkit.org/show_bug.cgi?id=99842

Attachment 172286: The patch to fix this problem (WinCairo port)
https://bugs.webkit.org/attachment.cgi?id=172286&action=review

------- Additional Comments from Hideki <yoshida-hxa at necst.nec.co.jp>
Ater my team debuged this problem,
we figured out that
calling scrollByRecursively fuction 
in Source/WebKit/win/WebView.cpp in line of 1663
causes this phenomenon.

The 2nd parameter for this function
must be specified whether ScrollOffsetUnclamped or 
ScrollOffsetClamped.
Because the call in the 1663rd line does not specify for the 2nd parameter,
the default value ScrollOffsetUnclamped is applied. That is the reason
why scroll is performed over the scroll limit area.

So we change the 1663rd line to specify ScrollOffsetClamped for the 2nd
parameter.
We have attached the patch, please review it.


More information about the webkit-reviews mailing list