[webkit-reviews] review granted: [Bug 101038] BaseChooserOnlyDateAndTimeInputType should implement DateTimeChooserClient : [Attachment 172262] Patch 2

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has granted Kent Tamura
<tkent at chromium.org>'s request for review:
Bug 101038: BaseChooserOnlyDateAndTimeInputType should implement
DateTimeChooserClient
https://bugs.webkit.org/show_bug.cgi?id=101038

Attachment 172262: Patch 2
https://bugs.webkit.org/attachment.cgi?id=172262&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172262&action=review


>>> Source/WebCore/html/BaseChooserOnlyDateAndTimeInputType.cpp:44
>>>  {
>> 
>> Can we ASSERT() that this is attached()?
>> Just for curious, what happens if a DOMActivate event is sent to the element
through JS?
> 
> I don't think ASSERT(element()->attached()) is correct because, as you know,
we can dispatch an event to a non-rendered element.
> In such case, the ScriptController::processingUserGesture() check below
rejects opening a DateTimeChooser.

OK, thanks for the explanation.