[webkit-reviews] review granted: [Bug 101178] [Shadow] ShadowRoot should have a method to return ShadowRootType : [Attachment 172272] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sun Nov 4 23:14:11 PST 2012
Hajime Morrita <morrita at google.com> has granted Shinya Kawanaka
<shinyak at chromium.org>'s request for review:
Bug 101178: [Shadow] ShadowRoot should have a method to return ShadowRootType
https://bugs.webkit.org/show_bug.cgi?id=101178
Attachment 172272: Patch
https://bugs.webkit.org/attachment.cgi?id=172272&action=review
------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=172272&action=review
> Source/WebCore/dom/ShadowRoot.h:119
> + ShadowRootType m_type : 1;
Is it possible to ensure that ShadowRootType can be fit into a bit?
Is STATIC_ASSERT or something helpful here?
More information about the webkit-reviews
mailing list