[webkit-reviews] review denied: [Bug 89638] Prep work for gradient interpolation. : [Attachment 148914] Patch

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Shane Stephens
<shanestephens at google.com>'s request for review:
Bug 89638: Prep work for gradient interpolation.
https://bugs.webkit.org/show_bug.cgi?id=89638

Attachment 148914: Patch
https://bugs.webkit.org/attachment.cgi?id=148914&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=148914&action=review


> It should be, but it's probably out of date. If someone is willing to review,
I'm very happy to bring the patch up-to-date with the tree.
The code basically looks fine. So I'm happy to help. Let's iterate a bit more.

> Source/WebCore/css/CSSGradientValue.cpp:579
> +float CSSLinearGradientValue::angleInDegrees() const

It's better to have this change when we actually use this. Otherwise we have
code with no test coverage, which is bad.