[webkit-reviews] review denied: [Bug 96592] Ruby text is incorrectly positioned when its writing-mode is changed to vertical after layout is done : [Attachment 171772] Fix test indications

[bugzilla-daemon at webkit.org]

Hajime Morrita <morrita at google.com> has denied Yuki Sekiguchi
<yuki.sekiguchi at access-company.com>'s request for review:
Bug 96592: Ruby text is incorrectly positioned when its writing-mode is changed
to vertical after layout is done
https://bugs.webkit.org/show_bug.cgi?id=96592

Attachment 171772: Fix test indications
https://bugs.webkit.org/attachment.cgi?id=171772&action=review

------- Additional Comments from Hajime Morrita <morrita at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=171772&action=review


> LayoutTests/fast/writing-mode/ruby-text-logical-left.html:26
> +	 setTimeout(function () {

Although there is no JS style guide for WebKit project, we usually follows one
of C++,
that means we does 4-space indent. See other tests as examples.

> LayoutTests/fast/writing-mode/ruby-text-logical-left.html:27
> +	   var e = document.getElementById("test1");

Please don't use abbreviation for the variable name.