[webkit-reviews] review denied: [Bug 101080] Color-profile property triggers assert : [Attachment 172101] Patch

[bugzilla-daemon at webkit.org]

Dirk Schulze <krit at webkit.org> has denied Florin Malita
<fmalita at chromium.org>'s request for review:
Bug 101080: Color-profile property triggers assert
https://bugs.webkit.org/show_bug.cgi?id=101080

Attachment 172101: Patch
https://bugs.webkit.org/attachment.cgi?id=172101&action=review

------- Additional Comments from Dirk Schulze <krit at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=172101&action=review


Since we don't handle it at all, why not do the same like for
background-enable:

	case CSSPropertyEnableBackground:
	    // Silently ignoring this property for now

Some might use at as feature detection. I would rather not enable it in CSSOM,
when we don't support it at all.

>> Source/WebCore/rendering/style/SVGRenderStyle.h:409
>> +	    unsigned _colorProfile : 1; // EColorProfile
> 
> _colorProfile is incorrectly named. Don't use underscores in your identifier
names.	[readability/naming/underscores] [4]

Well, it should still be fixed IMHO. Maybe in a preparation patch?